Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use typedef for private message ID's in callback #2729

Merged

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Mar 7, 2024

This change is Reviewable

@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Mar 7, 2024
@JFreegman JFreegman added this to the v0.2.19 milestone Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (7b1db6a) to head (32e67ab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
- Coverage   73.13%   73.09%   -0.04%     
==========================================
  Files         149      149              
  Lines       30516    30516              
==========================================
- Hits        22317    22305      -12     
- Misses       8199     8211      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JFreegman JFreegman marked this pull request as draft March 7, 2024 17:21
@JFreegman JFreegman force-pushed the private_message_id_type_fix branch from 2f2708e to 32e67ab Compare March 7, 2024 17:25
@JFreegman JFreegman marked this pull request as ready for review March 7, 2024 17:26
@toktok-releaser toktok-releaser merged commit 32e67ab into TokTok:master Mar 7, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

3 participants