fix: do proper groupchat cleanup on exit #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
force-pushed
the
group_cleanup_fix
branch
from
c1b28e8 to
6fe19dc
Compare
The wrong function was being called here. We need to call group_delete() on every group.
JFreegman
force-pushed
the
group_cleanup_fix
branch
from
6fe19dc to
b302056
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2608 +/- ##
==========================================
- Coverage 73.71% 73.68% -0.04%
==========================================
Files 148 148
Lines 30366 30365 -1
==========================================
- Hits 22384 22374 -10
- Misses 7982 7991 +9 ☔ View full report in Codecov by Sentry. |
|
This is fixed in #2609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong function was being called here. We need to call group_delete() on every group.
This change is