Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): window builds now build in parallel #2560

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Jan 14, 2024

noticed it was rather slow


This change is Reviewable

@Green-Sky Green-Sky requested a review from a team as a code owner January 14, 2024 10:06
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcb6592) 71.20% compared to head (acdc673) 71.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   71.20%   71.14%   -0.06%     
==========================================
  Files         127      127              
  Lines       28514    28514              
==========================================
- Hits        20302    20287      -15     
- Misses       8212     8227      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky
Copy link
Member Author

2m 35s -> 1m 23s

@Green-Sky Green-Sky added this to the v0.2.19 milestone Jan 14, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nurupo nurupo merged commit acdc673 into TokTok:master Jan 14, 2024
54 checks passed
@Green-Sky Green-Sky deleted the faster_window_ci branch March 8, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants