Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Move all vptr-to-ptr casts to the beginning of a function. #2512

Merged
merged 1 commit into from
Dec 30, 2023

cleanup: Move all vptr-to-ptr casts to the beginning of a function.

0e42752
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Move all vptr-to-ptr casts to the beginning of a function. #2512

cleanup: Move all vptr-to-ptr casts to the beginning of a function.
0e42752
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 30, 2023 in 0s

2 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Move all vptr-to-ptr casts to the beginning of a function.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : These casts are effectively part of the function type, so it makes sense to have them at the beginning.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}