-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix memory leak in the error path of loading savedata. #2424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2424 +/- ##
==========================================
+ Coverage 74.41% 74.49% +0.08%
==========================================
Files 87 87
Lines 26235 26243 +8
==========================================
+ Hits 19523 19551 +28
+ Misses 6712 6692 -20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 2 of 1 approvals obtained
Huh, how did this still use |
This is a 2 year old PR. I forgot to incorporate some recent changes into it, such as that, and groupchats. |
Was confused how did iphy miss those |
This change is