Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect documentation #2381

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Apr 5, 2023

This used to be the case but is no longer.


This change is Reviewable

@JFreegman JFreegman added the documentation Changes to the documentation label Apr 5, 2023
@JFreegman JFreegman added this to the v0.2.19 milestone Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2381 (8ed47f3) into master (a1e2458) will increase coverage by 0.00%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2381   +/-   ##
======================================
  Coverage    9.98%   9.99%           
======================================
  Files         141     141           
  Lines       32530   32530           
======================================
+ Hits         3247    3250    +3     
+ Misses      29283   29280    -3     

see 5 files with indirect coverage changes

Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained

The key used to get wiped on a kick but this is
no longer the case
@toktok-releaser toktok-releaser merged commit 8ed47f3 into TokTok:master Aug 23, 2023
@JFreegman JFreegman deleted the fix_ngc_doc branch August 23, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to the documentation
Development

Successfully merging this pull request may close these issues.

4 participants