fix: group custom packet size limits #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFreegman
added
bug
sudden6
reviewed
Nov 12, 2022
JFreegman
force-pushed
the
ngc_lossy_packet_size
branch
3 times, most recently
from
d681094 to
3b62e99
Compare
sudden6
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
@JFreegman if you feel like it you could add a link to the reasoning for the 500 byte packet size limit. Anyway the PR looks good to me now.
JFreegman
force-pushed
the
ngc_lossy_packet_size
branch
3 times, most recently
from
9848eca to
98fa2a3
Compare
JFreegman
force-pushed
the
ngc_lossy_packet_size
branch
2 times, most recently
from
f892b73 to
0a6512c
Compare
Lossy custom packets cannot be split, therefore they need to be limited to the maximum safe UDP packet size.
JFreegman
force-pushed
the
ngc_lossy_packet_size
branch
from
0a6512c to
b8aa21c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
- Coverage 78.17% 78.13% -0.05%
==========================================
Files 141 141
Lines 31097 31108 +11
==========================================
- Hits 24311 24306 -5
- Misses 6786 6802 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lossy custom packets cannot be split, therefore they need to be limited to the maximum safe UDP packet size.
This change is