Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing net to host conversion of port in logging #2339

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Oct 1, 2022

This change is Reviewable

@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label Oct 1, 2022
@Green-Sky Green-Sky force-pushed the net_logger_endianness branch from e732798 to 8054854 Compare October 1, 2022 18:22
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #2339 (8054854) into master (fb99aea) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   78.15%   78.12%   -0.03%     
==========================================
  Files         140      140              
  Lines       31045    31045              
==========================================
- Hits        24264    24255       -9     
- Misses       6781     6790       +9     
Impacted Files Coverage Δ
toxcore/network.c 88.08% <ø> (ø)
toxav/groupav.c 74.58% <0.00%> (-1.34%) ⬇️
toxcore/ping.c 85.80% <0.00%> (-1.24%) ⬇️
auto_tests/group_invite_test.c 98.44% <0.00%> (-0.78%) ⬇️
auto_tests/group_topic_test.c 95.71% <0.00%> (-0.72%) ⬇️
auto_tests/group_sync_test.c 84.65% <0.00%> (-0.47%) ⬇️
toxcore/net_crypto.c 87.28% <0.00%> (-0.15%) ⬇️
toxcore/group_chats.c 69.28% <0.00%> (-0.03%) ⬇️
toxcore/DHT.c 85.15% <0.00%> (ø)
toxcore/TCP_server.c 78.58% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JFreegman JFreegman added this to the v0.2.19 milestone Oct 1, 2022
@JFreegman JFreegman merged commit 8054854 into TokTok:master Oct 1, 2022
@Green-Sky Green-Sky deleted the net_logger_endianness branch March 8, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script
Development

Successfully merging this pull request may close these issues.

2 participants