Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle fix: Remove cmake cache files after copying to container build directory #2326

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Jul 4, 2022

A duplicate of #2325 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • shellharden

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/c-toxcore.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #2326 (f7b545f) into master (32ed67c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2326      +/-   ##
==========================================
- Coverage   78.93%   78.91%   -0.03%     
==========================================
  Files         127      127              
  Lines       24078    24078              
==========================================
- Hits        19007    19002       -5     
- Misses       5071     5076       +5     
Impacted Files Coverage Δ
toxav/bwcontroller.c 38.55% <0.00%> (-7.23%) ⬇️
toxcore/friend_connection.c 82.83% <0.00%> (-1.40%) ⬇️
toxav/toxav.c 69.23% <0.00%> (-0.15%) ⬇️
toxcore/net_crypto.c 87.36% <0.00%> (+0.07%) ⬆️
toxcore/DHT.c 83.94% <0.00%> (+0.07%) ⬆️
toxcore/TCP_server.c 78.77% <0.00%> (+0.18%) ⬆️
toxcore/TCP_connection.c 69.45% <0.00%> (+0.28%) ⬆️
toxcore/TCP_common.c 78.51% <0.00%> (+0.74%) ⬆️
toxcore/ping.c 87.03% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ed67c...f7b545f. Read the comment docs.

@Tha14
Copy link

Tha14 commented Jul 4, 2022

This should be closed btw. It seems like a wrong fix.
Ok, the restyle change works correctly after testing.
@JFreegman Please review if/when convenient.

@restyled-io restyled-io bot closed this Sep 27, 2022
@restyled-io restyled-io bot deleted the restyled/pull-2325 branch September 27, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script
Development

Successfully merging this pull request may close these issues.

2 participants