Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove check_recursion, since tokstyle checks this now. #2310

Closed
wants to merge 2 commits into from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Apr 25, 2022

And tokstyle is better at it, covering not just direct recursion, but
also (most possible instances of) recursion through function pointers.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Apr 25, 2022
@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Apr 25, 2022
@iphydf iphydf requested a review from a team as a code owner April 26, 2022 10:38
@iphydf
Copy link
Member Author

iphydf commented Apr 27, 2022

This can't be submitted until camgunz/cmp#69 is merged.

iphydf and others added 2 commits May 24, 2022 19:34
And tokstyle is better at it, covering not just direct recursion, but
also (most possible instances of) recursion through function pointers.
Bumps [third_party/cmp](https://github.com/camgunz/cmp) from `4c3737d` to `e836703`.
- [Release notes](https://github.com/camgunz/cmp/releases)
- [Commits](camgunz/cmp@4c3737d...e836703)

---
updated-dependencies:
- dependency-name: third_party/cmp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@iphydf iphydf force-pushed the check-recursion branch from 92265f2 to 3c569ab Compare May 24, 2022 19:34
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iphydf
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@sudden6
Copy link

sudden6 commented Jun 4, 2022

Done in #2318

@sudden6 sudden6 closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

4 participants