cleanup: Remove check_recursion, since tokstyle checks this now.

And tokstyle is better at it, covering not just direct recursion, but also (most possible instances of) recursion through function pointers.
TokTok · May 24, 2022 · d43acba · d43acba
1 parent 50094b7
commit d43acba
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 125 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -119,7 +119,6 @@ jobs:
       - run: git submodule update --init --recursive
       - run: other/analysis/check_includes
       - run: other/analysis/check_logger_levels
-      - run: other/analysis/run-check-recursion
       - run: other/analysis/run-clang
       - run: other/analysis/run-cppcheck
       - run: other/analysis/run-gcc

diff --git a/.github/scripts/flags-clang.sh b/.github/scripts/flags-clang.sh
@@ -15,6 +15,8 @@ add_flag -Wno-conversion
 # TODO(iphydf): Check enum values when received from the user, then assume
 # correctness and remove this suppression.
 add_flag -Wno-covered-switch-default
+# We use C99, so declarations can come after statements.
+add_flag -Wno-declaration-after-statement
 # Due to clang's tolower() macro being recursive
 # https://github.com/TokTok/c-toxcore/pull/481
 add_flag -Wno-disabled-macro-expansion

diff --git a/other/analysis/check_recursion b/other/analysis/check_recursion
diff --git a/other/analysis/run-check-recursion b/other/analysis/run-check-recursion