chore: Enable compiler layering check.

This ensures that we're explicit about what we depend on and avoids transitive dependencies.
TokTok · Jan 11, 2022 · c1b32bd · c1b32bd
1 parent eebc516
commit c1b32bd
Show file tree

Hide file tree

Showing 4 changed files with 135 additions and 12 deletions.
diff --git a/other/bootstrap_daemon/BUILD.bazel b/other/bootstrap_daemon/BUILD.bazel
@@ -1,5 +1,7 @@
 load("@rules_cc//cc:defs.bzl", "cc_binary")
 
+package(features = ["layering_check"])
+
 cc_binary(
     name = "bootstrap_daemon",
     srcs = glob([
@@ -9,6 +11,13 @@ cc_binary(
     deps = [
         "//c-toxcore/other:bootstrap_node_packets",
         "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:DHT",
+        "//c-toxcore/toxcore:TCP_connection",
+        "//c-toxcore/toxcore:ccompat",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
+        "//c-toxcore/toxcore:network",
+        "//c-toxcore/toxcore:onion_announce",
         "@libconfig",
     ],
 )
diff --git a/testing/BUILD.bazel b/testing/BUILD.bazel
@@ -1,5 +1,7 @@
 load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
 
+package(features = ["layering_check"])
+
 CIMPLE_FILES = [
     "//c-toxcore/toxav:cimple_files",
     "//c-toxcore/toxcore:cimple_files",
@@ -20,7 +22,11 @@ cc_library(
     srcs = ["misc_tools.c"],
     hdrs = ["misc_tools.h"],
     visibility = ["//c-toxcore:__subpackages__"],
-    deps = ["//c-toxcore/toxcore"],
+    deps = [
+        "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:ccompat",
+        "@libsodium",
+    ],
 )
 
 cc_library(
@@ -35,7 +41,10 @@ cc_binary(
     srcs = ["DHT_test.c"],
     deps = [
         ":misc_tools",
-        "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:DHT",
+        "//c-toxcore/toxcore:Messenger",
+        "//c-toxcore/toxcore:friend_requests",
+        "//c-toxcore/toxcore:mono_time",
     ],
 )
 
@@ -44,7 +53,8 @@ cc_binary(
     srcs = ["Messenger_test.c"],
     deps = [
         ":misc_tools",
-        "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:Messenger",
+        "//c-toxcore/toxcore:mono_time",
     ],
 )
 

diff --git a/toxav/BUILD.bazel b/toxav/BUILD.bazel
@@ -1,6 +1,8 @@
 load("@rules_cc//cc:defs.bzl", "cc_test")
 load("//tools:no_undefined.bzl", "cc_library")
 
+package(features = ["layering_check"])
+
 filegroup(
     name = "public_headers",
     srcs = ["toxav.h"],
@@ -25,6 +27,7 @@ cc_test(
     srcs = ["ring_buffer_test.cc"],
     deps = [
         ":ring_buffer",
+        "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
     ],
 )
@@ -47,14 +50,23 @@ cc_library(
         ":ring_buffer",
         "//c-toxcore/toxcore",
         "//c-toxcore/toxcore:Messenger",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
+        "//c-toxcore/toxcore:network",
     ],
 )
 
 cc_library(
     name = "rtp",
     srcs = ["rtp.c"],
     hdrs = ["rtp.h"],
-    deps = [":bwcontroller"],
+    deps = [
+        ":bwcontroller",
+        "//c-toxcore/toxcore:Messenger",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
+        "//c-toxcore/toxcore:network",
+    ],
 )
 
 cc_test(
@@ -64,6 +76,7 @@ cc_test(
     deps = [
         ":rtp",
         "//c-toxcore/toxcore:crypto_core",
+        "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
     ],
 )
@@ -75,6 +88,8 @@ cc_library(
     deps = [
         ":public",
         ":rtp",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
         "//c-toxcore/toxcore:network",
         "@opus",
     ],
@@ -93,6 +108,10 @@ cc_library(
     deps = [
         ":audio",
         ":public",
+        ":ring_buffer",
+        ":rtp",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
         "//c-toxcore/toxcore:network",
         "@libvpx",
     ],
@@ -104,6 +123,9 @@ cc_library(
     hdrs = ["groupav.h"],
     deps = [
         "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
+        "//c-toxcore/toxcore:network",
         "@opus",
     ],
 )
@@ -120,7 +142,12 @@ cc_library(
     visibility = ["//c-toxcore:__subpackages__"],
     deps = [
         ":groupav",
+        ":rtp",
         ":video",
+        "//c-toxcore/toxcore:Messenger",
+        "//c-toxcore/toxcore:logger",
+        "//c-toxcore/toxcore:mono_time",
+        "//c-toxcore/toxcore:network",
     ],
 )