Skip to content

Commit

Permalink
EDAC/ghes: Remove unused members of struct ghes_edac_pvt, rename it t…
Browse files Browse the repository at this point in the history
…o ghes_pvt

The struct members list and ghes of struct ghes_edac_pvt are unused,
remove them. On that occasion, rename it to the shorter name struct
ghes_pvt.

Signed-off-by: Robert Richter <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
  • Loading branch information
Robert Richter authored and suryasaimadhu committed Jun 16, 2020
1 parent cb51a37 commit b001694
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions drivers/edac/ghes_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
#include "edac_module.h"
#include <ras/ras_event.h>

struct ghes_edac_pvt {
struct list_head list;
struct ghes *ghes;
struct ghes_pvt {
struct mem_ctl_info *mci;

/* Buffers for the error handling routine */
Expand All @@ -32,7 +30,7 @@ static refcount_t ghes_refcount = REFCOUNT_INIT(0);
* also provides the necessary (implicit) memory barrier for the SMP
* case to make the pointer visible on another CPU.
*/
static struct ghes_edac_pvt *ghes_pvt;
static struct ghes_pvt *ghes_pvt;

/* GHES registration mutex */
static DEFINE_MUTEX(ghes_reg_mutex);
Expand Down Expand Up @@ -212,7 +210,7 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err)
{
struct edac_raw_error_desc *e;
struct mem_ctl_info *mci;
struct ghes_edac_pvt *pvt;
struct ghes_pvt *pvt;
unsigned long flags;
char *p;

Expand Down Expand Up @@ -470,7 +468,7 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev)
bool fake = false;
int rc = 0, num_dimm = 0;
struct mem_ctl_info *mci;
struct ghes_edac_pvt *pvt;
struct ghes_pvt *pvt;
struct edac_mc_layer layers[1];
struct ghes_edac_dimm_fill dimm_fill;
unsigned long flags;
Expand Down Expand Up @@ -507,15 +505,14 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev)
layers[0].size = num_dimm;
layers[0].is_virt_csrow = true;

mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(struct ghes_edac_pvt));
mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(struct ghes_pvt));
if (!mci) {
pr_info("Can't allocate memory for EDAC data\n");
rc = -ENOMEM;
goto unlock;
}

pvt = mci->pvt_info;
pvt->ghes = ghes;
pvt->mci = mci;

mci->pdev = dev;
Expand Down

0 comments on commit b001694

Please sign in to comment.