TIQR-478: Feature flag for Android

Tiqr · Oct 25, 2024 · 42297d8 · 42297d8
1 parent 78e1515
commit 42297d8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/app/src/main/kotlin/nl/eduid/flags/FeatureFlag.kt b/app/src/main/kotlin/nl/eduid/flags/FeatureFlag.kt
@@ -16,10 +16,10 @@ enum class FeatureFlag(
         explanation = "When on, it will show the `Add a security key` on the Security screen",
         defaultValue = false,
     ),
-    SHOW_VERIFY_IDENTITY(
-        key = "show_verify_identity",
-        title = "Show verify identity feature",
-        explanation = "When on, the functionality for verifying identity is visible & accessible.",
+    ENABLE_IDENTITY_VERIFICATION(
+        key = "enable_identity_verification",
+        title = "Enable Identity Verification",
+        explanation = "When on, it will enable the user to verify their identity via a third party",
         defaultValue = false,
     ),
 }
diff --git a/app/src/main/kotlin/nl/eduid/screens/homepage/HomePageNoAccount.kt b/app/src/main/kotlin/nl/eduid/screens/homepage/HomePageNoAccount.kt
@@ -288,11 +288,11 @@ fun HomePageNoAccountContent(
                     onClick = {
                         if (isAuthorizedForDataAccess) {
                             viewModel.startEnrollmentAfterSignIn()
+                            waitingForVmEvent = true
                         } else {
                             wasOAuthTriggered = true
                             onGoToSignIn()
                         }
-                        waitingForVmEvent = true
                     },
                     modifier = Modifier
                         .fillMaxWidth()

diff --git a/app/src/main/kotlin/nl/eduid/screens/oauth/OAuthScreen.kt b/app/src/main/kotlin/nl/eduid/screens/oauth/OAuthScreen.kt
@@ -62,11 +62,9 @@ fun OAuthScreen(
     var oAuthUiStages by rememberSaveable { mutableStateOf(OAuthUiStages()) }
     val activity = LocalContext.current
     Timber.e("Current activity is launching oauth: ${activity.hashCode()}")
-//    Timber.w("Started OAuthScreen with state: $uiState.\n\t IsAuthorizationLaunched: ${oAuthUiStages.isAuthorizationLaunched}.\n\t IsFetchingToken: ${oAuthUiStages.isFetchingToken}")
     val context = LocalContext.current
     val launcher =
         rememberLauncherForActivityResult(contract = OAuthContract(), onResult = { intent ->
-//            Timber.e("1 - Received intent fro AppAuth")
             viewModel.continueWithFetchToken(intent)
             //Move to the next stage for fetching the token
             oAuthUiStages = OAuthUiStages(