Excludes include directory aliases #432
Conversation
|
Hey Ash! Long time no see! Oh wow! Artsy is using this library!? That's fantastic to hear! Thank you! I'm so happy it was useful for you folks! Awesome! Thanks so much for that! Admittedly SPM support for this library isn't fantastic, so I wouldn't be surprised if more of these issues were still in there. That all looks good to me! Thanks again! If there's anything I can do to help with this library for Artsy's needs, please let me know! Take care! |
Merge pull request TimOliver#432 from ashfurrow/master
|
@TimOliver Yeah you too! I was happy to see your GitHub handle when I looked up this repo 😄 The only other thing I'd like to ask is, could I trouble you to make a new release of this library with the change? That would solve the problems for users in #424 as well as ivpusic/react-native-image-crop-picker#1397 🙇 I hope you're well, and take care! |
|
@ashfurrow Haha thanks! Yeah I'm doing well. I hope you've been safe in NY all this time! No worries! All done! Version 2.5.5 should be finished deploying at this point. Please let me know if you find any issues with it. Thanks Ash! You take care too! Hope we can catch up again soon! :) |
|
Just tested and it works for me! Thanks again |
|
Hi guys, Still doesn't work on Xcode 12.1 and the latest library 2.5.5 :( |
|
Also getting this error here. pod version 1.10.0 |
I have tested this out locally and this fixes the pod install warnings. Inspired by @ashfurrow solution TimOliver/TOCropViewController#432. Fixes CleverTap/clevertap-ios-sdk/CleverTap#271
We've been using this dependency at Artsy for a few months with CocoaPods, via react-native-image-crop-picker, and have ran into problems with duplicate UUIDs and build warnings related to duplicated header files. I found #424 which seemed to describe the problem we were having and I think I have a solution.
The
Objective-C/TOCropViewController/includedirectory seems to include a bunch of aliased header files, and a module map. These header files point to actual files, but they get included in the generated Pods Xcode project twice (once for the original header, and once for the alias). This means that the deterministically-generated UUID will be duplicated (it's the same file) and the headers get included twice in the Xcode project. It seems these aliases are important for SPM so the easiest way to solve the problem is have CocoaPods ignore them.My solution is to exclude those header aliases, while still including the module map, using the
exclude_filesin the podspec. I've tested this out locally and this fixes both thepod installwarnings and build time Xcode warnings.Let me know if I can clarify anything at all, and thank you for the really cool project 🙏
Fixes #424.