Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now building with Swift 5 and updated README.md #343

Merged
merged 7 commits into from
Apr 21, 2019
Merged

Now building with Swift 5 and updated README.md #343

merged 7 commits into from
Apr 21, 2019

Conversation

OscarGorog
Copy link
Contributor

CropViewController is now being build with Swift 5. Also, the README.md now includes all examples in Swift.

Thanks!

@TimOliver
Copy link
Owner

Oh nice! Thanks for the PR @OkiRules!

Uhhh, this commit log is a bit of a mess though. GitHub is saying 95 files were changed. How did you do that? 😅

@OscarGorog
Copy link
Contributor Author

Sorry! I'm not that experienced with Pull Requests! 😅
I hope that all the changes are OK though...

Thanks!

@yarodevuci
Copy link

@TimOliver

Oh nice! Thanks for the PR @OkiRules!

Uhhh, this commit log is a bit of a mess though. GitHub is saying 95 files were changed. How did you do that? 😅

Probably automatic conversion ?! Can you merge this?

@danqing
Copy link

danqing commented Apr 19, 2019

Looks like you need to change file mode from 755 back to 644.

@TimOliver TimOliver merged commit 69a0093 into TimOliver:master Apr 21, 2019
@TimOliver
Copy link
Owner

Okay! I had some time free this weekend so I managed to go through this PR and cleaned it up.

I made sure your commits remained intact @OkiRules, so your GitHub account now shows you're a contributor to this project. :)

There's still a few more PRs I need to go through, so I'll do a new release when they're finished.

Thanks again for the help!

@OscarGorog
Copy link
Contributor Author

Thanks @TimOliver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants