Fix unreliable power-on on some machines #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TillFleisch
force-pushed
the
increase_max_repetitions_fix_power_on
branch
from
187bdf6 to
420e1a4
Compare
Closed
TillFleisch
added a commit
that referenced
this pull request
Feb 14, 2024
)" This reverts commit 77ecf73.
TillFleisch
added a commit
that referenced
this pull request
Feb 14, 2024
davidepanato
added a commit
to davidepanato/ESPHome-Philips-Smart-Coffee
that referenced
this pull request
Feb 22, 2024
Increase message repetition count for power on/off messages (TillFleisch#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the message repetition count for power related messages. As mentioned in #19 and #30 this resolve a
powering onissue on some machines. This change should have no side effects on other machines.Close #30
Close #19