Remove windows 2019 CI / update to windows 2022 #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
Jan 7, 2025
|
This is a breaking change for the release binaries for Windows, as they now require a newer version of the MSVC redistributables. Not a bad thing to do, but we should document it in the release notes. |
Is there an action item for this PR? If so I'd like to update the appropriate doc before merging instead of after |
|
You can just update the DESC field in your PR's description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conda feedstock is on VS2022, so we have no need to keep the 2019 CI.
This also reduces the need for developers to have to support older compilers.
TYPE: BREAKING_BEHAVIOR
DESC: the release binaries for Windows now require MSVC 2022.