Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subarray CAPI Handle. #5334

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Subarray CAPI Handle. #5334

merged 5 commits into from
Oct 9, 2024

Conversation

bekadavis9
Copy link
Contributor

Subarray CAPI Handle.

[sc-53777]

TYPE: NO_HISTORY
DESC: Subarray CAPI Handle.

@bekadavis9
Copy link
Contributor Author

Blocked pending merge of #5327.

@bekadavis9 bekadavis9 requested a review from ihnorton October 3, 2024 16:49
@ihnorton ihnorton requested a review from teo-tsirpanis October 4, 2024 01:14
@bekadavis9 bekadavis9 marked this pull request as ready for review October 4, 2024 13:52
teo-tsirpanis
teo-tsirpanis approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teo-tsirpanis
Copy link
Member

I must say I've been recently starting to fail to see the value of the CAPIHandle refactoring effort and also think that we're getting too granular with modularizing the Core into object libraries, but it might be too late to suggest changing course, considering that there are only four handles left to migrate, and that the refactorings themselves are not a negative but IMHO just a waste of time compared to their advantages.

@bekadavis9 bekadavis9 merged commit 5bf1baf into dev Oct 9, 2024
63 checks passed
@bekadavis9 bekadavis9 deleted the rd/CAPIs-subarray branch October 9, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekadavis9 @teo-tsirpanis