Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable whiteboxallocator tests, fix gcc-13 build #4291

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Disable whiteboxallocator tests, fix gcc-13 build #4291

merged 2 commits into from
Aug 23, 2023

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Aug 22, 2023 •
edited
Loading

Fixes #4191.

Test follow-up in sc-33182.

TYPE: BUILD
DESC: Disable whiteboxallocator tests, fix gcc-13 build in #4191

@ihnorton ihnorton force-pushed the ihn/gcc-13-test branch 2 times, most recently from 8a16f86 to 15b68b0 Compare August 22, 2023 12:05
@ihnorton ihnorton requested a review from teo-tsirpanis August 22, 2023 12:05
@teo-tsirpanis
Copy link
Member

I haven't understood why calling make_shared_whitebox fails to compile. Is there a way to fix that instead of disabling the tests?

eric-hughes-tiledb
eric-hughes-tiledb reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer these tests only be commented out only for gcc-13. This code is relatively fragile and the tests should not be removed, as someone coming in cold would naturally do, not seeing conditional removal.

tiledb/common/dynamic_memory/test/unit_dynamic_memory.cc Outdated Show resolved Hide resolved
@ihnorton
Copy link
Member Author

Is there a way to fix that instead of disabling the tests?

I have tried several times and end up in (more) template error soup. We are going to refactor to use the new C++20 allocator style deriving from memory_resource, so deferring for now.

@ihnorton ihnorton merged commit 3ef79f7 into dev Aug 23, 2023
@ihnorton ihnorton deleted the ihn/gcc-13-test branch August 23, 2023 13:00
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-hughes-tiledb eric-hughes-tiledb eric-hughes-tiledb left review comments

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

@davisp davisp Awaiting requested review from davisp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instantiation of function template specialization in tests fails on Alpine Linux Edge
3 participants
@ihnorton @teo-tsirpanis @eric-hughes-tiledb