Legacy reader: reading non written region causes segfault. #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault.
|
This pull request has been linked to Shortcut Story #30952: [TileDB Cloud crash dumps] Reader::copy_partitioned_fixed_cells.. |
Shelnutt2
approved these changes
Aug 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault. (cherry picked from commit 64b2f64)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault. (cherry picked from commit 64b2f64)
KiterLuc
added a commit
that referenced
this pull request
Aug 8, 2023
…4255) This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault. (cherry picked from commit 64b2f64) Co-authored-by: KiterLuc <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Aug 8, 2023
…4254) This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault. (cherry picked from commit 64b2f64) Co-authored-by: KiterLuc <[email protected]>
davisp
pushed a commit
to davisp/TileDB
that referenced
this pull request
Sep 6, 2023
…c#4253) This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not. --- TYPE: IMPROVEMENT DESC: Legacy reader: reading non written region causes segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with legacy dense reads where reading a region that is not written causes segfault. In this case, the reader generates a cell slab with a nullptr tile, which signals the copy function to return the fill value for those cells. The nullptr value was causing an issue when trying to determine if a field is present or not.
TYPE: IMPROVEMENT
DESC: Legacy reader: reading non written region causes segfault.