Update VFS S3 to ListObjectsV2 #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #31529: Recursively find files matching a pattern with VFS. |
robertbindar
approved these changes
Aug 1, 2023
davisp
pushed a commit
to davisp/TileDB
that referenced
this pull request
Sep 6, 2023
This updates `VFS::ls` implementation for S3 to call ListObjectsV2 from the AWS SDK, which increases performance when listing a prefix with several objects. This came up while working on SC-31529 after testing recursive ls performance with ~350k results. ListObjectsV1 completes in ~10 minutes while ListObjectsV2 completes in 1 minute. --- TYPE: IMPROVEMENT DESC: Update VFS to call ListObjectsV2 from the AWS SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
VFS::lsto call ListObjectsV2 from the AWS SDK, which increases performance when listing a prefix with several objects.This came up while working on SC-31529 after testing recursive ls performance with ~350k results. ListObjectsV1 completes in ~10 minutes while ListObjectsV2 completes in 1 minute.
TYPE: IMPROVEMENT
DESC: Update VFS to call ListObjectsV2 from the AWS SDK.