Fix bug loading var sized tiles in dense_reader #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #29682: Error in utf8 query condition. |
Shelnutt2
approved these changes
May 31, 2023
ihnorton
approved these changes
May 31, 2023
KiterLuc
reviewed
May 31, 2023
davisp
force-pushed
the
pd/sc-29682/fix-rest-400-error-code
branch
2 times, most recently
from
704a41f to
3fc4d5c
Compare
Before we were only checking attribute names from set buffers instead of all the condition value field names.
davisp
force-pushed
the
pd/sc-29682/fix-rest-400-error-code
branch
from
3fc4d5c to
6a2b765
Compare
|
@Shelnutt2 I added a regression test to make sure it doesn't pop back in later. @KiterLuc I'm not sure what you meant by extracting as a static function for unit testing. Did you just mean that bit of logic around gathering the names into two vectors or something more complicated to affect all of the readers? |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
Before we were only checking attribute names from set buffers instead of all the condition value field names.
Shelnutt2
pushed a commit
that referenced
this pull request
Jun 1, 2023
Before we were only checking attribute names from set buffers instead of all the condition value field names. Co-authored-by: Paul J. Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were only checking attribute names from set buffers instead of all the condition value field names.
TYPE: BUG
DESC: Fix dense reader error when query conditions reference var sized fields.