Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Query::est_result_size_nullable on remote arrays #4079

Merged
merged 2 commits into from
May 4, 2023
Merged

Allow Query::est_result_size_nullable on remote arrays #4079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccc163
WIP: Nullable est result size debug
bekadavis9 May 3, 2023
bac8b6c
Allow Query::est_result_size_nullable for remote arrays
bekadavis9 May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tiledb/sm/query/query.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,8 @@ Status Query::get_est_result_size_nullable(
"array with no rest client."));
}

return logger_->status(
Status_QueryError("Error in query estimate result size; unimplemented "
"for nullable attributes in remote arrays."));
RETURN_NOT_OK(
rest_client->get_query_est_result_sizes(array_->array_uri(), this));
}

return subarray_.get_est_result_size_nullable(
Expand Down Expand Up @@ -311,9 +310,8 @@ Status Query::get_est_result_size_nullable(
"array with no rest client."));
}

return logger_->status(
Status_QueryError("Error in query estimate result size; unimplemented "
"for nullable attributes in remote arrays."));
RETURN_NOT_OK(
rest_client->get_query_est_result_sizes(array_->array_uri(), this));
}

return subarray_.get_est_result_size_nullable(
Expand Down