Silence warnings on unqualified calls to std::move #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #27254: Avoid unqualified calls to |
davisp
force-pushed
the
pd/sc-27254/silence-unqualified-move-warnings
branch
from
6c7717a to
c658ddc
Compare
KiterLuc
approved these changes
Apr 4, 2023
This is a new compiler warning add to at least Apple Clang. For now we're choosing to silence the warning until at least other compilers come to an agreement on whether this should be a warning.
davisp
force-pushed
the
pd/sc-27254/silence-unqualified-move-warnings
branch
from
c658ddc to
0c27de0
Compare
ihnorton
approved these changes
Apr 4, 2023
davisp
added a commit
that referenced
this pull request
Jun 16, 2023
This is a new compiler warning add to at least Apple Clang. For now we're choosing to silence the warning until at least other compilers come to an agreement on whether this should be a warning. --- TYPE: IMPROVEMENT DESC: Silence warnings about unqualified calls to std::move on Apple Clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new compiler warning add to at least Apple Clang. For now we're choosing to silence the warning until at least other compilers come to an agreement on whether this should be a warning.
TYPE: IMPROVEMENT
DESC: Silence warnings about unqualified calls to std::move on Apple Clang