Make sure metadata are deleted when they got added in the same operation. #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. And add a test.
|
This pull request has been linked to Shortcut Story #25089: Creating/mutating and deleting metadata elements in one transaction results in them still being around. |
ihnorton
reviewed
Apr 4, 2023
teo-tsirpanis
commented
Apr 4, 2023
Co-authored-by: Isaiah Norton <[email protected]>
ihnorton
approved these changes
Apr 4, 2023
|
Hmm, the serialization failure seems related. 🤔 |
|
All right, CI is now green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-25089
I added the story's reproduction for groups as a test. It fails before the fix and succeeds after it. Ideally it would reside in the metadata unit tests but I can do it as part of the refactorings in #4012; let's fix the bug now.
TYPE: BUG
DESC: Fix array/group metadata deletion when they are inserted in the same operation.