Update Subarray Cap'n Proto serialization to include label ranges #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22385: Update Query Cap'n Proto to support label queries. |
ypatia
force-pushed
the
yt/ch22385/labels_capnp_subarray
branch
from
8edac4e to
9a18407
Compare
ypatia
force-pushed
the
yt/ch22385/labels_capnp_subarray
branch
from
9a18407 to
946b0b8
Compare
|
[sc-22384] |
|
This pull request has been linked to Shortcut Story #22384: Update Subarray Cap'n Proto to support label and attr ranges. |
shaunrd0
approved these changes
Mar 16, 2023
|
This pull request has been linked to Shortcut Story #22385: Update Query Cap'n Proto to support label queries. |
jp-dark
approved these changes
Apr 5, 2023
ihnorton
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of the work to add serialization support for dimension labels. It is adding label ranges to the
Subarraycapnp format andsubarray_to/from_capnpfunctions.For now only 1 test is added, but a wrapper test function is provided in this PR and can be used to enhance other existing tests that use label ranges to increase coverage.
After this part is merged, then
Update Query Cap'n Proto to support label queriesis the last (and probably most complex) part of dimension label serialization work left.TYPE: IMPROVEMENT
DESC: Update Subarray Cap'n Proto serialization to include label ranges