Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "vfs.s3.no_sign_request" #3953

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Shelnutt2
Copy link
Member

This option allows the user to make anonymous s3 API requests similar to the "--no-sign-request" for the aws cli. This is handy when a user wants to access a public s3 bucket and does not have credentials defined.

Fixes #3951


TYPE: FEATURE
DESC: Introduce "vfs.s3.no_sign_request" to allow unsigned s3 API calls, useful for anonymous s3 bucket access.

@Shelnutt2 Shelnutt2 requested review from ihnorton and KiterLuc March 9, 2023 01:01
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #26201: Support aws no-sign-request.

@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-26201/support-aws-no-sign-request branch from a112680 to 6716d8d Compare March 17, 2023 18:53
This option allows the user to make anonymous s3 API requests similar to
the "--no-sign-request" for the aws cli. This is handy when a user wants
to access a public s3 bucket and does not have credentials defined.

Fixes #3951
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/sc-26201/support-aws-no-sign-request branch from 6716d8d to 024d5f7 Compare March 17, 2023 19:59
@ihnorton ihnorton merged commit 2f6cfc6 into dev Mar 20, 2023
@ihnorton ihnorton deleted the sethshelnutt/sc-26201/support-aws-no-sign-request branch March 20, 2023 12:12
github-actions bot pushed a commit that referenced this pull request Mar 20, 2023
This option allows the user to make anonymous s3 API requests similar to the "--no-sign-request" for the aws cli. This is handy when a user wants to access a public s3 bucket and does not have credentials defined.

Fixes #3951

---
TYPE: FEATURE
DESC: Introduce "vfs.s3.no_sign_request" to allow unsigned s3 API calls, useful for anonymous s3 bucket access.
ihnorton pushed a commit that referenced this pull request Mar 21, 2023
This option allows the user to make anonymous s3 API requests similar to the "--no-sign-request" for the aws cli. This is handy when a user wants to access a public s3 bucket and does not have credentials defined.

Fixes #3951

---
TYPE: FEATURE
DESC: Introduce "vfs.s3.no_sign_request" to allow unsigned s3 API calls, useful for anonymous s3 bucket access.

Co-authored-by: Seth Shelnutt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 request signing should be configurable
3 participants