Add unit_platform tests #3936
Merged
Add unit_platform tests #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #25878: Add unit_platform tests. |
I tried using platform.h in a separate PR which broke the build on Windows from what was apparently an incorrectly set `is_os_windows` setting. I'm adding these tests to assert that OS type is correctly identified. Note that I'm relying on CMake's `CMAKE_SYSTEM_NAME` variable here to do platform detection. This means that our OS detection is only as good as CMake's detection which I have no reason to distrust. Secondly, I'm ignoring any platform that isn't Windows, macOS, or Linux and just logging an error. This is on purpose so that these don't suddenly break a bunch of downstream package builds.
davisp
force-pushed
the
pd/sc-25878/add-unit-platform-tests
branch
from
1428763 to
2263143
Compare
ihnorton
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using platform.h in a separate PR which broke the build on Windows from what was apparently an incorrectly set
is_os_windowssetting. I'm adding these tests to assert that OS type is correctly identified.Note that I'm relying on CMake's
CMAKE_SYSTEM_NAMEvariable here to do platform detection. This means that our OS detection is only as good as CMake's detection which I have no reason to distrust. Secondly, I'm ignoring any platform that isn't Windows, macOS, or Linux and just logging an error. This is on purpose so that these don't suddenly break a bunch of downstream package builds.TYPE: IMPROVEMENT
DESC: Add unit tests for tiledb/common/platform.h