Refactor readers to use optional<QueryCondition> #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #19640: Make query_condition optional.. |
davisp
force-pushed
the
pd/sc-19640/refactor-reader-base-query-condition
branch
4 times, most recently
from
7242b1d to
389ed95
Compare
KiterLuc
suggested changes
Feb 20, 2023
davisp
force-pushed
the
pd/sc-19640/refactor-reader-base-query-condition
branch
from
389ed95 to
c169fb9
Compare
davisp
force-pushed
the
pd/sc-19640/refactor-reader-base-query-condition
branch
2 times, most recently
from
51c5f9c to
7fa1d8f
Compare
davisp
force-pushed
the
pd/sc-19640/refactor-reader-base-query-condition
branch
from
7fa1d8f to
d0d14a1
Compare
KiterLuc
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor readers to use
std::optional<QueryCondition>TYPE: IMPROVEMENT
DESC: Refactor readers to use
std::optional<QueryCondition>