Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out no-op set_config calls: Query #3884

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Error out no-op set_config calls: Query #3884

merged 3 commits into from
Apr 1, 2023

Conversation

bekadavis9
Copy link
Contributor

Setting a config on a Query is a no-op once Query::init() has been called, so throw accordingly. Add unsafe_set_config to maintain serialization behavior until C.41 compliance. Change Subarray::set_config to type void and adjust error handling within the class.

TYPE: IMPROVEMENT
DESC: Error out no-op set_config calls, Query

@bekadavis9 bekadavis9 requested a review from ihnorton February 10, 2023 21:50
@ihnorton ihnorton merged commit a333b75 into dev Apr 1, 2023
@ihnorton ihnorton deleted the rd/error_handling-set_config-query branch April 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekadavis9 @ihnorton