Dictionary encoding should handle zero length strings #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero length strings are valid and supported by TileDB. The zero length encoding had some safety checks were got tripped up. This adjusts the checks and adds a unit test to ensure support going forward.
|
This pull request has been linked to Shortcut Story #20973: DictionaryEncoding size should support empty string. |
Shelnutt2
deleted the
sethshelnutt/sc-20973/dictionaryencoding-size-should-support-empty
branch
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
Zero length strings are valid and supported by TileDB. The zero length encoding had some safety checks were got tripped up. This adjusts the checks and adds a unit test to ensure support going forward.
ihnorton
pushed a commit
that referenced
this pull request
Sep 1, 2022
Zero length strings are valid and supported by TileDB. The zero length encoding had some safety checks were got tripped up. This adjusts the checks and adds a unit test to ensure support going forward. Co-authored-by: Seth Shelnutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero length strings are valid and supported by TileDB. The zero length encoding had some safety checks were got tripped up. This adjusts the checks and adds a unit test to ensure support going forward.
TYPE: BUG
DESC: Dictionary encoding should handle zero length strings