Integrate baseline object library into the main build #2916
Conversation
|
This pull request has been linked to Shortcut Story #15115: Integrate baseline object library into the main build. |
| @@ -37,6 +37,7 @@ if (TILEDB_TESTS) | |||
| endif() | |||
|
|
|||
| get_gathered(COMMON_SOURCES) | |||
| list(REMOVE_ITEM COMMON_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/governor/governor.cc) | |||
There was a problem hiding this comment.
This line is a symptom that's something's wrong. It can't stay. If an integration with baseline is requiring ad hoc exceptions like this, we need to get whatever's causing the problem changed and not just mask over the problem with a statement like this one.
| @@ -398,6 +393,9 @@ endif() | |||
| # so we can use the targets created by the calls to find_package(). | |||
| add_library(TILEDB_CORE_OBJECTS_ILIB INTERFACE) | |||
|
|
|||
| # Link baseline library | |||
| target_link_libraries(TILEDB_CORE_OBJECTS_ILIB INTERFACE baseline) | |||
There was a problem hiding this comment.
The installation errors are coming from attaching the object library to the interface, which propagates dependency from baseline onto the interface.
It looks like TILEDB_CORE_OBJECTS is the right target to attach baseline to. Will also need it in TILEDB_CORE_OBJECTS_STATIC if so.
The CMake INTERFACE specifier is wrong here. PRIVATE is what you want, otherwise all the dependencies of the object libraries propagate upward.
|
Closing since we plan to implement this a different way in 2.19. |
[SC-15115](https://app.shortcut.com/tiledb-inc/story/15115/integrate-baseline-object-library-into-the-main-build) Supersedes #2916. --- TYPE: IMPROVEMENT DESC: Integrate baseline object library into the main build
Changed a few lines of CMake to add baseline as a library, then integrated it into the main build.
TYPE: IMPROVEMENT
DESC: Integrate baseline object library into the main build