Nullable attribute result size estimation APIs #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatia
reviewed
Dec 2, 2020
joe-maley
force-pushed
the
jpm/estimate-null-result
branch
from
1547575 to
25cec8f
Compare
joe-maley
force-pushed
the
jpm/estimate-null-result
branch
from
25cec8f to
1d36918
Compare
stavrospapadopoulos
approved these changes
Dec 2, 2020
joe-maley
force-pushed
the
jpm/consistent-est-cpp-api
branch
5 times, most recently
from
8604b82 to
5b6f175
Compare
This adds the C/C++ APIs for getting estimated result sizes. Note that this API will error-out at runtime for rest arrays because we don't currently have a REST API for this.
joe-maley
force-pushed
the
jpm/estimate-null-result
branch
from
1d36918 to
da0a1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the C/C++ APIs for getting estimated result sizes. Note that this
API will error-out at runtime for rest arrays because we don't currently have
a REST API for this.
Contains a bug-fix and some clean up in the estimation logic in
subarray.cc.