Only serialize Array URI if client side #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
force-pushed
the
sethshelnutt/ch3164/don-t-return-array-uri-in-schema-serverside
branch
from
bdd102d to
89d0070
Compare
joe-maley
reviewed
Sep 21, 2020
| @@ -41,6 +41,7 @@ | |||
|
|
|||
| * Fixed bug in setting a fill value for var-sized attributes. | |||
| * Fixed a bug where the cpp headers would always produce compile-time warnings about using the deprecated c-api "tiledb_coords()" [#1765](https://github.com/TileDB-Inc/TileDB/pull/1765) | |||
| * Only serialize the Array URI in the array schema client size. [#1806](https://github.com/TileDB-Inc/TileDB/pull/1806) | |||
Shelnutt2
force-pushed
the
sethshelnutt/ch3164/don-t-return-array-uri-in-schema-serverside
branch
3 times, most recently
from
31916a8 to
60cf498
Compare
We should avoid returning the absolute array URI in the schema when sending from server to client. Only serialize the array if we are client side, in which case the URI was already known to open the array.
Shelnutt2
force-pushed
the
sethshelnutt/ch3164/don-t-return-array-uri-in-schema-serverside
branch
from
60cf498 to
50a76b9
Compare
Shelnutt2
deleted the
sethshelnutt/ch3164/don-t-return-array-uri-in-schema-serverside
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid returning the absolute array URI in the schema when sending from server to client. Only serialize the array if we are client side, in which case the URI was already known to open the array.