Remove use of TILEDB_COORDS in cpp-api #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TILEDB_COORDS macro invokes `tiledb_coords()` which is tagged for compile-time deprecation. To avoid compile-time warnings when importing the cpp-api, we must not use the TILEDB_COORDS macro. This patch hard-codes the "__coords" name. This is reasonably safe because the named-coordinate attribute exists for backwards compatability and will not be changed in the future.
stavrospapadopoulos
approved these changes
Aug 12, 2020
Shelnutt2
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TILEDB_COORDS macro invokes
tiledb_coords()which is tagged forcompile-time deprecation. To avoid compile-time warnings when importing the
cpp-api, we must not use the TILEDB_COORDS macro. This patch hard-codes the
"__coords" name. This is reasonably safe because the named-coordinate attribute
exists for backwards compatability and will not be changed in the future.