Fix undefined behavior within load_tile_var_sizes #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
approved these changes
Jul 28, 2020
The `load_tile_var_sizes` is not thread-safe between TBB tasks because it locks with an stdlib mutex. This change ensures that access to FragmentMetadata instances are serialized.
joe-maley
force-pushed
the
jpm/fix-fragment-hang
branch
from
d2d5de5 to
03f69e2
Compare
Shelnutt2
approved these changes
Jul 28, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2020
The `load_tile_var_sizes` is not thread-safe between TBB tasks because it locks with an stdlib mutex. This change ensures that access to FragmentMetadata instances are serialized. Co-authored-by: Joe Maley <[email protected]>
Shelnutt2
pushed a commit
that referenced
this pull request
Jul 29, 2020
The `load_tile_var_sizes` is not thread-safe between TBB tasks because it locks with an stdlib mutex. This change ensures that access to FragmentMetadata instances are serialized. Co-authored-by: Joe Maley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
load_tile_var_sizesis not thread-safe between TBB tasks because itlocks with an stdlib mutex. This change ensures that access to FragmentMetadata
instances are serialized.