Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement seek function for curl posts #1728

Merged

Conversation

Shelnutt2
Copy link
Member

This allows for redirects to be successful in POSTing data from curl over REST. A new BufferList::seek(offset, whence) function was added to facilitate this.

@Shelnutt2 Shelnutt2 requested review from ihnorton and joe-maley July 18, 2020 13:59
Copy link
Contributor

@joe-maley joe-maley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few style nitpicks

tiledb/sm/buffer/buffer_list.h Outdated Show resolved Hide resolved
tiledb/sm/buffer/buffer_list.cc Outdated Show resolved Hide resolved
tiledb/sm/buffer/buffer_list.cc Outdated Show resolved Hide resolved
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for branch from a69044d to 766c178 Compare July 18, 2020 19:02
This allows for redirects to be successful in POSTing data from curl
over REST. A new `BufferList::seek(offset, whence)` function was added
to facilitate this.
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for branch from 766c178 to 15a6fc5 Compare July 18, 2020 19:03
@Shelnutt2 Shelnutt2 merged commit 604f2fa into dev Jul 20, 2020
@Shelnutt2 Shelnutt2 deleted the sethshelnutt/ch879/need-to-implement-curlopt-seekfunction-for branch July 20, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants