ResultTile::coord() performance #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the branch within the ResultTile::coord() implementation to test if it contains zipped or unzipped coordinates. The function contract is slightly modified because now the caller must ensure that an underlying coordinate exists at there requested position and dimension. Currently, the `ResultTile::coord()` may return null if nothing is found. This does not appear to be an expected output anywhere in the unit tests or code. In a certain read benchmark that paths through this routine multiple times, this patch reduces the avg execution time from 18.15s to 17.00s.
stavrospapadopoulos
approved these changes
Jun 16, 2020
joe-maley
pushed a commit
that referenced
this pull request
Jul 22, 2020
This removes the branch within the ResultTile::coord() implementation to test if it contains zipped or unzipped coordinates. The function contract is slightly modified because now the caller must ensure that an underlying coordinate exists at there requested position and dimension. Currently, the `ResultTile::coord()` may return null if nothing is found. This does not appear to be an expected output anywhere in the unit tests or code. In a certain read benchmark that paths through this routine multiple times, this patch reduces the avg execution time from 18.15s to 17.00s.
Shelnutt2
pushed a commit
that referenced
this pull request
Jul 22, 2020
This removes the branch within the ResultTile::coord() implementation to test if it contains zipped or unzipped coordinates. The function contract is slightly modified because now the caller must ensure that an underlying coordinate exists at there requested position and dimension. Currently, the `ResultTile::coord()` may return null if nothing is found. This does not appear to be an expected output anywhere in the unit tests or code. In a certain read benchmark that paths through this routine multiple times, this patch reduces the avg execution time from 18.15s to 17.00s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the branch within the ResultTile::coord() implementation to
test if it contains zipped or unzipped coordinates.
The function contract is slightly modified because now the caller must ensure
that an underlying coordinate exists at there requested position and dimension.
Currently, the
ResultTile::coord()may return null if nothing is found. Thisdoes not appear to be an expected output anywhere in the unit tests or code.
In a certain read benchmark that paths through this routine multiple times,
this patch reduces the avg execution time from 18.15s to 17.00s.