Ubuntu's capnp-dev package is missing targets #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
force-pushed
the
ss/adjust-findcapnp_ep-for-ubuntu
branch
from
30b0964 to
9641d73
Compare
ihnorton
approved these changes
May 28, 2020
Shelnutt2
force-pushed
the
ss/adjust-findcapnp_ep-for-ubuntu
branch
2 times, most recently
from
2adcf67 to
cfc1003
Compare
Shelnutt2
force-pushed
the
ss/adjust-findcapnp_ep-for-ubuntu
branch
3 times, most recently
from
b3bf113 to
21b8ab8
Compare
Shelnutt2
added
backport release-2.0.4
and removed
backport
We need to handle a capnproto install without targets by checking for the CAPNP_LIBRARIES and making sure all needed libraries are available. Ubuntu 18.04's capnproto 0.6.1 package is missing the libcapnp-json so we need to use super build in that case.
Shelnutt2
force-pushed
the
ss/adjust-findcapnp_ep-for-ubuntu
branch
from
21b8ab8 to
517a208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle a capnproto install without targets by checking for the
CAPNP_LIBRARIESand making sure all needed libraries are available. Ubuntu 18.04's capnproto 0.6.1 package is missing the libcapnp-json so we need to use super build in that case.Note: This does not solve the problem of checking for capnproto version mismatches. I'll open a story to do this as a followup.
This is based on #1658 to avoid rebase conflicts. I'll rebase once that one is merged.
[ch2388]