Allow empty values for variable length attributes #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
approved these changes
May 16, 2020
Shelnutt2
force-pushed
the
sethshelnutt/ch2300/allow-empty-variable-length-attributes-in
branch
2 times, most recently
from
a79e1fd to
4ec43ed
Compare
The ascending order check for offsets is relaxed to allow two or more
succeeding values to have the same offset. This allows for a zero length
value to on one more cells of a variable length attribute.
Currently writting a single empty value is not supported. Empty cells
must be part of a write that includes at least 1 cell with values.
Consider the following examples:
Write to 4 cells (1-4) where the 4th cell of a1 is empty
d1 = {1, 2, 3, 4}
a1_data = {1, 2, 3}
a1_offsets = {0, 1, 2, 3}
write to 4 cells (1-4) where the 2nd cell of a1 is empty
d1 = {1, 2, 3, 4}
a1_data = {1, 2, 3}
a1_offsets = {0, 1, 1, 2}
Shelnutt2
force-pushed
the
sethshelnutt/ch2300/allow-empty-variable-length-attributes-in
branch
from
4ec43ed to
6f3d632
Compare
Shelnutt2
deleted the
sethshelnutt/ch2300/allow-empty-variable-length-attributes-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ascending order check for offsets is relaxed to allow two or more succeeding values to have the same offset. This allows for a zero length value to on one more cells of a variable length attribute.
Currently writing a single empty value is not supported. Empty cells must be part of a write that includes at least 1 cell with values.
Consider the following examples:
Write to 4 cells (1-4) where the 4th cell of a1 is empty
d1 = {1, 2, 3, 4}
a1_data = {1, 2, 3}
a1_offsets = {0, 1, 2, 3}
write to 4 cells (1-4) where the 2nd cell of a1 is empty
d1 = {1, 2, 3, 4}
a1_data = {1, 2, 3}
a1_offsets = {0, 1, 1, 2}