VFS: Support GCS #1585
Merged
VFS: Support GCS #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-maley
force-pushed
the
jpm/gcs-vfs
branch
2 times, most recently
from
96407b5 to
a280de2
Compare
ihnorton
approved these changes
Apr 9, 2020
|
Comment about config, otherwise LGTM once the tests pass (some tests segfaulted due to context creation failure) |
joe-maley
force-pushed
the
jpm/gcs-vfs
branch
2 times, most recently
from
4b99f1d to
0c54aed
Compare
joe-maley
commented
Apr 9, 2020
joe-maley
force-pushed
the
jpm/gcs-vfs
branch
2 times, most recently
from
3bb1d61 to
73a6959
Compare
ihnorton
requested changes
Apr 9, 2020
This is the final functional patch planned for initial GCS support. The GCS backend is already complete, this change just enables the VFS to use it when the core is built with GCS.
ihnorton
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final functional patch planned for initial GCS support. The GCS
backend is already complete, this change just enables the VFS to use it when
the core is built with GCS.