Skip to content

Commit

Permalink
Fix whitespace (unrelated to PR)
Browse files Browse the repository at this point in the history
  • Loading branch information
ihnorton committed Aug 2, 2022
1 parent ed40669 commit bf465c3
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/mingw-w64-tiledb/PKGBUILD
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ build() {
..
make
make -C tiledb

# in a local environ, can build to demo/check for previously seen (windows event) handle leakge
# apparently due to issues with mingw std library implementation.
# note that with S3 enabled above, and minio not running, the aws sdk may fatally error on exit.
Expand Down
2 changes: 1 addition & 1 deletion format_spec/consolidated_commits_file.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ my_array # array folder
* `uuid` is a unique identifier
* `v` is the format version

There may be multiple such files in the array commits folder. Each consolidated commits file combines a list of fragments commits or delete commits.
There may be multiple such files in the array commits folder. Each consolidated commits file combines a list of fragments commits or delete commits.
| **Field** | **Type** | **Description** |
| :--- | :--- | :--- |
| Commit 1 | `uint8_t[]` | Commit 1 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ TEST_CASE_METHOD(
auto timestamps_ptr =
GENERATE_REF(as<std::vector<uint64_t>*>{}, nullptr, &timestamps);

uint64_t tstamp = 7;
uint64_t tstamp = 7;
SECTION("Read after all writes") {
// Read after both writes - should see everything.
tstamp = 7;
Expand Down
4 changes: 2 additions & 2 deletions tiledb/api/C_API_STRUCTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
The C API consists of layers starting with the API functions themselves and ending with classes that call into the non-API parts of the core library. There are five layers, each with its own responsibilities.

### Public API functions

Public API functions themselves are declared with `extern "C"` linkage. They are implemented as wrappers around an API implementation function. There is a one-to-one relationship between public API functions and API implementation functions.

Public API functions are responsible for uniform error processing through handling exceptions. The wrapper provides uniformity of behavior for (1) return values, (2) logging format, (3) error return. Non-uniform error handling may be done outside this layer, although that's not usually necessary.
Public API functions are responsible for uniform error processing through handling exceptions. The wrapper provides uniformity of behavior for (1) return values, (2) logging format, (3) error return. Non-uniform error handling may be done outside this layer, although that's not usually necessary.

### API implementation functions

Expand Down
4 changes: 2 additions & 2 deletions tiledb/api/c_api/DIRECTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

The C API code is in sections, roughly one for each type exposed through the API.
Each section has its own directory, containing two headers, at least one API source file, and unit tests.

* **External header**. This header is included in the top-level `tiledb.h` header. These headers will be included in both C and C++ programs and must compile appropriately.
* Declares C API functions.
* Only included in `tiledb.h`. Should not appear elsewhere, including in other external headers.
Expand All @@ -11,7 +11,7 @@ Each section has its own directory, containing two headers, at least one API sou
* Uses name convention `<section>_api_external.h`
* **Internal header**. This header is not user-visible and is for inclusion in API source files.
* Only included in API sources and API white-box unit tests. Since these headers are not user-visible, they do not appear in integration tests; such test should only use external headers.
* Included source files in other sections as the arguments of C API function dictate.
* Included source files in other sections as the arguments of C API function dictate.
* Uses name convention `<section>_api_internal.h`
* **API source**
* Defines C API functions with an exception wrapper around a matching implementation function.
Expand Down
6 changes: 3 additions & 3 deletions tiledb/storage_format/DIRECTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ Each of these entities may be regarded as having syntax and semantics: what a va
Here's a partial list of concerns that are out of scope:

* **Storage access.** Nothing in this directory has direct access to an object store or a file system. A user of these classes must provide the results of a storage operation to this code for parsing and interpretation.
* **State maintenance.** This code has the notion of an "array in a directory", but it does not provide any notion of "the current state" of an array in storage. The concept here is that of an array a data type, not as a variable of that data type.
* **State maintenance.** This code has the notion of an "array in a directory", but it does not provide any notion of "the current state" of an array in storage. The concept here is that of an array a data type, not as a variable of that data type.

## Useful Information
The following is the list of Datatypes that are **not** supported by the Dimension class.
Please note that this information is repeated in the C API, C++ API, and the Dimension class.
The following is the list of Datatypes that are **not** supported by the Dimension class.
Please note that this information is repeated in the C API, C++ API, and the Dimension class.

* TILEDB_CHAR
* TILEDB_BLOB
Expand Down

0 comments on commit bf465c3

Please sign in to comment.