Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyBind11 Wrap FilterList and Filter Classes #921

Merged
merged 16 commits into from
Mar 7, 2022
Merged

PyBind11 Wrap FilterList and Filter Classes #921

merged 16 commits into from
Mar 7, 2022

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Feb 18, 2022

No description provided.

ihnorton
ihnorton reviewed Feb 18, 2022
View reviewed changes
tiledb/cc/CMakeLists.txt Outdated Show resolved Hide resolved
nguyenv
nguyenv commented Feb 18, 2022
View reviewed changes
tiledb/filter.py Outdated Show resolved Hide resolved
@ihnorton ihnorton mentioned this pull request Mar 1, 2022
Closed
@nguyenv nguyenv force-pushed the pybind11-wrap-filter-filterlist branch from 7901e95 to 3b476fc Compare March 3, 2022 22:42
ihnorton
ihnorton approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits and then let's get this merged 🚀 Really nice work on passing FilterList between cython and pybind11, it looks really clean!

tiledb/filter.py Outdated Show resolved Hide resolved
tiledb/libtiledb.pxd Outdated Show resolved Hide resolved
tiledb/cc/filter.cc Show resolved Hide resolved
tiledb/libtiledb.pyx Show resolved Hide resolved
ihnorton and others added 16 commits March 7, 2022 15:28
@ihnorton
pybind11 wrapping and tests for context, config, query, schema
885d7a9
@ihnorton
Add setup.py support for tiledb.cc
9e73d5c
@nguyenv @ihnorton
Release 0.12.1 Against 0.6.1
159e93d
@ihnorton
Parallel compilation mode using pybind11 helper if available
25d6dbf
@nguyenv @ihnorton
Add Bindings for Filter and FilterList
e45dc7b
@nguyenv @ihnorton
Modify setup.py To Add lib and include Dirs
ddf280f 
* Append C++17 flag
* Move `from .libtiledb import Ctx` into filter classes
@ihnorton
Fix build error with GCC 7
05523f0
@ihnorton
Fix import error due to missing fvisibility flag
a0f538e
@nguyenv @ihnorton
Replace ssize_t With py::ssize_t; Remove Unused Vars
8a2836c
@nguyenv @ihnorton
Reformat With clang-format v9.0.0
ba0fb61
@nguyenv @ihnorton
Refactor Filter Classes Into Regular Classes
e80fbe5 
* Ensure typing is correct against PyRight
@nguyenv @ihnorton
Remove CMakeLists.txt
e0e3339
@nguyenv @ihnorton
Use typing.TYPE_CHECKING for Ctx
349fc14
@nguyenv @ihnorton
Handle TILEDB_BLOB In cc/common.cc
7f16d21
@nguyenv @ihnorton
Delete Unused Filter/FilterList Declarations from libtiledb
b14a91b
@nguyenv @ihnorton
Make filter_type_cc_to_python a class member
5c31cee
@ihnorton ihnorton force-pushed the pybind11-wrap-filter-filterlist branch from 486542b to 5c31cee Compare March 7, 2022 20:28
@nguyenv nguyenv merged commit f3d3897 into dev Mar 7, 2022
@nguyenv nguyenv deleted the pybind11-wrap-filter-filterlist branch March 7, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyenv @ihnorton