Modified stats_dump() To Return Internal Stats As String #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
requested changes
Oct 28, 2020
nguyenv
force-pushed
the
vn/stat_dump_to_fp
branch
2 times, most recently
from
b3069dc to
93ea38d
Compare
ihnorton
approved these changes
Oct 31, 2020
Previously, tiledb_stats_dump() output to stdout. However, Jupyter notebooks do not capture or redirect external stdout and thus were not able to display internal stats. tiledb_stats_dump() now outputs to a temporary file which is then converted to a Python string. This also required a to print_stats() which has been renamed to python_internal_stats(). Previously, print_stats() output the internal stats to stdout. The modified function returns a std::string.
nguyenv
force-pushed
the
vn/stat_dump_to_fp
branch
from
93ea38d to
e4e76c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tiledb_stats_dump() output to stdout. However, Jupyter notebooks
do not capture or redirect external stdout and thus were not able to display
internal stats. tiledb_stats_dump() now outputs to a temporary file which is
then converted to a Python string.
[ch3357]