Add support for 'capacity' as kwarg and 'tile' as dict of extents (from_csv/pandas) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
reviewed
Oct 7, 2020
ihnorton
force-pushed
the
ihn/from_csv_capacity
branch
from
5bee825 to
c750ca0
Compare
Supports passing `tile` kwarg of type Dict[Str->[Int,Float]] to specify the tile extent to apply to any dimensions (tiledb.Dim) created for indexes. If no tiling is specified then the existing internal default will be used.
ihnorton
requested review from
Shelnutt2 and
normanb
and removed request for
normanb
ihnorton
changed the title
Shelnutt2
approved these changes
Oct 7, 2020
…internally) (also prefix csv_schema_only test w/ dataframe_ so it runs under `pytest -k dataframe`)
|
👍 looks good. |
normanb
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following for from_csv and from_pandas
{name: extent}pairs