Set start/end_buf_ptr for var size nonEmptyDomain #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
May 12, 2020
|
@ihnorton I'm not sure about the OSX failure here. Is that a transient failure? |
|
I saw that once before, but couldn't reproduce it locally or on CI. Will dig in a bit more. |
This fixes a case where for dimensions which are fixed length and end_buf_ptr is not set resulting in: `nboundLocalError: local variable 'end_buf' referenced before assignment`
ihnorton
force-pushed
the
sethshelnutt/ch2251/unboundlocalerror-local-variable-end-buf
branch
from
547b8d9 to
3994b0c
Compare
|
@Shelnutt2 I couldn't reproduce, going to make the failure into a warning up to 3x per attempt, and see if it is repeatable within a given run. See 981719e |
Merged
ihnorton
deleted the
sethshelnutt/ch2251/unboundlocalerror-local-variable-end-buf
branch
ihnorton
added a commit
that referenced
this pull request
May 14, 2020
ihnorton
added a commit
that referenced
this pull request
May 14, 2020
antalakas
pushed a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where for dimensions which are fixed length and end_buf_ptr is not set resulting in:
nboundLocalError: local variable 'end_buf' referenced before assignment