Remove Cython Dependency #2118
Merged
Remove Cython Dependency #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
pybind11-full
branch
from
76e62f6 to
5b8cf68
Compare
kounelisagis
force-pushed
the
agis/drop-cython
branch
from
81e1719 to
9a69c87
Compare
|
A lot of changes are made here but it looks good to me, of course all CI tests must pass. Also, don't forget that we need to update |
nguyenv
approved these changes
Dec 9, 2024
|
🚀 |
kounelisagis
added a commit
that referenced
this pull request
Dec 20, 2024
* Move version method to pybind11 * Delete libtiledb.pyx, libtiledb.pxd, and common.pxi * Add __iter__ for FragmentsInfoIterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency of the repository on
Cython. From this point onward,pybind11will be the sole way for communicating withlibtiledb. This change will simplify maintenance, reducing complexity and ensuring a more streamlined development process for future updates.cc: @dudoslav for visibility.
[sc-59525]