Change minimum libtiledb version for CurrentDomain to 2.26 to fix daily tests
#2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
changed the title
CurrentDomain to fix daily testsCurrentDomain to 2.26 fix daily tests
ihnorton
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM.
Note that IF we ever create a new 0.31.* release against 2.25, this PR cannot be included. However, making such a release would require a release branch from the original release tag, manual backports, etc. So please just make a note in the merge commit that this PR cannot be included in a 0.31.* release.
kounelisagis
changed the title
CurrentDomain to 2.26 fix daily testsCurrentDomain to 2.26 to fix daily tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2111 caused the daily tests to fail. The error indicates that the latest code is not compatible with the libtiledb 2.25.X binaries, since I make use of
range_dtypefunction which was introduced in 2.26.0.To address this, I suggest updating the required version for the current domain. Manually triggering the workflow for this branch appears to resolve the issue: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/12122419572. Our wheels built against 2.25.X should remain unaffected.
Other possible solutions include:
To make something out of this, I would also suggest adding a backward compatibility job in a future PR to our regular CI, derived from the daily tests, to help prevent similar issues in the future.