Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Query to pure Python #2106

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Move Query to pure Python #2106

merged 3 commits into from
Nov 13, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Nov 5, 2024 •
edited
Loading

@kounelisagis kounelisagis changed the base branch from dev to pybind11-full November 5, 2024 17:09
@kounelisagis kounelisagis requested review from nguyenv and ihnorton and removed request for nguyenv November 6, 2024 14:38
@kounelisagis kounelisagis marked this pull request as ready for review November 6, 2024 14:38
nguyenv
nguyenv reviewed Nov 7, 2024
View reviewed changes
tiledb/query.py Outdated Show resolved Hide resolved
tiledb/query.py Outdated Show resolved Hide resolved
tiledb/query.py Outdated Show resolved Hide resolved
@kounelisagis kounelisagis requested a review from nguyenv November 8, 2024 12:13
nguyenv
nguyenv approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. I think your conditional refactor reads much easier than what was there previously. The type hints are extremely useful here since dims and attrs being both bool and Sequence[str] was not very obvious.

@kounelisagis kounelisagis merged commit 8b1c59f into pybind11-full Nov 13, 2024
27 checks passed
@kounelisagis kounelisagis deleted the agis/move-query-python branch November 13, 2024 23:33
kounelisagis added a commit that referenced this pull request Dec 9, 2024
@kounelisagis
Move Query to pure Python (#2106)
88e5075 
* Move Query to pure Python
* Add type hints, add docstring, improve code clarity
kounelisagis added a commit that referenced this pull request Dec 20, 2024
@kounelisagis
Move Query to pure Python (#2106)
35ca257 
* Move Query to pure Python
* Add type hints, add docstring, improve code clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenv nguyenv nguyenv approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kounelisagis @nguyenv